fix go mTOn filter bug #3144
Merged
fix go mTOn filter bug #3144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevermore3
added
type/bug
nevermore3
force-pushed
the
fix_go_mton_bug
branch
from
36aab70 to
b8eea5f
Compare
yixinglu
reviewed
Oct 19, 2021
nevermore3
added
ready-for-testing
czpmango
reviewed
Oct 19, 2021
Comment on lines
506
to
509
| const auto& projectInput = | ||
| (joinInput || joinDst) ? loopBody->outputVar() : sampleLimit->outputVar(); | ||
| (loopBody != getDst) ? loopBody->outputVar() : sampleLimit->outputVar(); | ||
| loopBody = Project::make(qctx, loopBody, goCtx_->yieldExpr); | ||
| loopBody->setInputVar(projectInput); |
There was a problem hiding this comment.
Why not delete these codes?
There was a problem hiding this comment.
execution flow and data flow are sometimes inconsistent, so explicit input is required
There was a problem hiding this comment.
I still think there is redundant code logic and the Project node has nothing to do with getDst
There was a problem hiding this comment.
loopbody may be getDst or filter, but the input of project can only be sample or filter， This is why you need to specify the project's input
Codecov Report
@@ Coverage Diff @@
## master #3144 +/- ##
==========================================
+ Coverage 84.98% 85.01% +0.03%
==========================================
Files 1289 1289
Lines 117763 117759 -4
==========================================
+ Hits 100076 100116 +40
+ Misses 17687 17643 -44
Continue to review full report at Codecov.
|
CPWstatic
previously approved these changes
Oct 19, 2021
nevermore3
force-pushed
the
fix_go_mton_bug
branch
from
ffe5626 to
8597495
Compare
CPWstatic
approved these changes
Oct 20, 2021
yixinglu
approved these changes
Oct 20, 2021
Sophie-Xie
pushed a commit
that referenced
this pull request
Oct 20, 2021
* fix go mTOn filter bug * add test case
bright-starry-sky
pushed a commit
that referenced
this pull request
Oct 20, 2021
* Fixed an issue where the server still started with a wrong ip/host (#3057) * Fix wrong local ip. * Address comment. * Fix alter drop (#3036) * disable modify same col * add test case * refactor ddl * fix pytest error * address comment Co-authored-by: Yee <[email protected]> * fix fetch vertex properties(vertex) bug (#3120) * fix fetch vertex properties(vertex) bug * address comment Co-authored-by: Yee <[email protected]> * fix go yield bug (#3128) * fix go yield bug * add test case * Remove unnecessary check (#3112) Co-authored-by: cpw <[email protected]> Co-authored-by: Yee <[email protected]> * fix go mTOn filter bug (#3144) * fix go mTOn filter bug * add test case * Geo spatial: 3. geography schema, data, index and optimization (#3043) * Geo spatial: 3. geography data and index Co-authored-by: cpw <[email protected]> Co-authored-by: jimingquan <[email protected]> Co-authored-by: Yee <[email protected]> Co-authored-by: Yichen Wang <[email protected]> Co-authored-by: jie.wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3090